[bazel] NFC: Change tbl_outs to dicts.
#137788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some `gentbl_cc_library` targets left to convert. Allow `gentbl_filegroup` rule to take a dict as well and change all targets. Move lld/BUILD.bazel from //llvm:tblgen.bzl to //mlir:tblgen.bzl, delete the former. This makes the BUILD files shorter and more readable.
akuegel
approved these changes
Apr 29, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
There were some `gentbl_cc_library` targets left to convert. Allow `gentbl_filegroup` rule to take a dict as well and change all targets. Move lld/BUILD.bazel from //llvm:tblgen.bzl to //mlir:tblgen.bzl, delete the former. This makes the BUILD files shorter and more readable.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
There were some `gentbl_cc_library` targets left to convert. Allow `gentbl_filegroup` rule to take a dict as well and change all targets. Move lld/BUILD.bazel from //llvm:tblgen.bzl to //mlir:tblgen.bzl, delete the former. This makes the BUILD files shorter and more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some
gentbl_cc_librarytargets left to convert.Allow
gentbl_filegrouprule to take a dict as well and change all targets.Move lld/BUILD.bazel from //llvm:tblgen.bzl to //mlir:tblgen.bzl, delete the former.
This makes the BUILD files shorter and more readable.